Skip to content

fix IO objects refcounting #8481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
directionless merged 2 commits into from
Dec 12, 2024
Merged

fix IO objects refcounting #8481

directionless merged 2 commits into from
Dec 12, 2024

Conversation

@vcheckin-uptycs
Copy link
Contributor

@vcheckin-uptycs vcheckin-uptycs commented Nov 26, 2024

Experiencing random crashes in iokit thread on USB unplug.

Crashed Thread:        22  iokit

Exception Type:        EXC_GUARD (SIGKILL)
Exception Codes:       GUARD_TYPE_MACH_PORT
Exception Codes:       0x0000000000005c03, 0x0000000000000000
...
Thread 22 Crashed:: iokit
0   libsystem_kernel.dylib        	       0x18da69ce4 _kernelrpc_mach_port_deallocate_trap + 8
1   libsystem_kernel.dylib        	       0x18da6b11c mach_port_deallocate + 28
2   IOKit                         	       0x191536678 IODispatchCalloutFromCFMessage + 396
3   CoreFoundation                	       0x18dbbf1d0 __CFMachPortPerform + 296
4   CoreFoundation                	       0x18db922c8 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 60
5   CoreFoundation                	       0x18db921e8 __CFRunLoopDoSource1 + 524
6   CoreFoundation                	       0x18db90b48 __CFRunLoopRun + 2248
7   CoreFoundation                	       0x18db8fbc4 CFRunLoopRunSpecific + 588
8   CoreFoundation                	       0x18dc0ae50 CFRunLoopRun + 64

This PR aims to fix couple of refcounting issues in iokit.cpp:

  1. IOObjectRelease(device) is called in some paths of DeleteDevice. The callback operates on a "borrowed" reference and shouldn't release it.
  2. IOReleaseObject(notification) is called twice. Converting to RAII style management of notification object.

@vcheckin-uptycs vcheckin-uptycs requested review from a team as code owners November 26, 2024 19:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 26, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

directionless
directionless previously approved these changes Dec 1, 2024
View reviewed changes
@directionless directionless merged commit 717749d into osquery:master Dec 12, 2024
22 checks passed
@vcheckin-uptycs vcheckin-uptycs deleted the iokit-refcount branch December 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@directionless directionless directionless approved these changes

Assignees

No one assigned

Labels

bug macOS virtual tables

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vcheckin-uptycs @directionless @michael-myers