Skip to content

Conversation

@ilpianista
Copy link
Contributor

My osquery with debug logs is logging:

Failed to read the extensions file at: /home/XYZ/.mozilla/firefox/Crash Reports/extensions.json, error: Cannot open file for reading: /home/XYZ/.mozilla/firefox/Crash Reports/extensions.json
Failed to read the extensions file at: /home/andrea/.mozilla/firefox/Pending Pings/extensions.json, error: Cannot open file for reading: /home/andrea/.mozilla/firefox/Pending Pings/extensions.json

I think we should just exclude those folders from the profiles list.

@ilpianista ilpianista requested review from a team as code owners November 20, 2024 08:03
@michael-myers michael-myers changed the title bugfix: browser_firefox exclude Crash Reports and Pending Pings folders bugfix: Make browser_firefox exclude "Crash Reports" and "Pending Pings" folders Dec 17, 2024
@michael-myers
Copy link
Contributor

Hi @ilpianista the CI fails the code style check, but you can run the step explained here and push a new commit to make it pass: https://osquery.readthedocs.io/en/latest/development/building/#formatting-the-code

I agree the two directories you mention should not be searched as if they were Profiles. Do you know if those names are always the same across platforms and language localizations?

@ilpianista
Copy link
Contributor Author

Hi @ilpianista the CI fails the code style check, but you can run the step explained here and push a new commit to make it pass: https://osquery.readthedocs.io/en/latest/development/building/#formatting-the-code

Thanks, fixed!

I agree the two directories you mention should not be searched as if they were Profiles. Do you know if those names are always the same across platforms and language localizations?

I'm not 100% sure, but I found the Italian documentation page about crash reports and it mention the ~/.mozilla/firefox/Crash Reports/ folder, so, apparently, no translation is performed.

directionless
directionless previously approved these changes Dec 17, 2024
@directionless
Copy link
Member

I think the CI failure is real:

/__w/osquery/osquery/workspace/padding-required-by-rpm-packages/src/osquery/tables/applications/browser_firefox.cpp:202:48: error: no member named 'ends_with' in 'std::__1::basic_string<char>'
                                      return s.ends_with("Crash Reports") ||

@directionless directionless changed the title bugfix: Make browser_firefox exclude "Crash Reports" and "Pending Pings" folders Update the browser_firefox table to exclude "Crash Reports" and "Pending Pings" folders Dec 30, 2024
@directionless directionless merged commit 6a8a7f7 into osquery:master Dec 30, 2024
22 checks passed
@ilpianista ilpianista deleted the bugfix/firefox-extensions-paths branch December 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants