Remove yara schema subdirectory #8461
Conversation
Windows is erroneously output for the yara_events table even though there is not actually support for yara_events on Windows.
tools/codegen/genwebsitejson.py
Outdated
| if path.endswith("yara_events.table"): | ||
| return ["darwin", "linux"] |
There was a problem hiding this comment.
Should we move the spec? Could add a yara/posix. Approved, anyway you'd like to handle it
There was a problem hiding this comment.
I think we should just remove the special cases and actually move the .table in the existing linux, posix etc (depending on where it has to go). This would go under posix.
yara, utility and sleuthkit seem to be the only remaining special cases
There was a problem hiding this comment.
I agree actually. I don't see much benefit of the special case directories. If they aren't important to the build process in some way then that would be my preference.
There was a problem hiding this comment.
I agree actually. I don't see much benefit of the special case directories. If they aren't important to the build process in some way then that would be my preference.
No they aren't. I guess previously it was preferred to give priority to what the table spec was for.
specs/CMakeLists.txt
Outdated
| "windows/security_profile_info.table:windows" | ||
| "windows/windows_search.table:windows" | ||
| "yara/yara_events.table:linux,macos" | ||
| "yara/yara.table:linux,macos,windows" |
There was a problem hiding this comment.
Do we also want to move yara.table?
There was a problem hiding this comment.
Yes. I'm working on this now.
|
@directionless @Smjert I added some additional changes to eliminate the |
Uh oh!
There was an error while loading. Please reload this page.