CI: Add a specific package build folder on Windows jobs #8446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zwass
previously approved these changes
Oct 17, 2024
Member
Author
|
Sorry, should've put this in draft; seems the artifacts have not been uploaded for Windows, so there's some place I may have missed something. |
The packaging logic expects to enter into a specific folder to create Windows packages inside. This folder was not being created and the workflow was not complaining for its absence, using the root of the workspace. Add the folder as it exists for the other jobs.
4533743 to
ef369ec
Compare
| working-directory: ${{ steps.build_paths.outputs.PACKAGE_BUILD }} | ||
| id: packages | ||
| shell: bash | ||
| shell: powershell |
Member
There was a problem hiding this comment.
This doesn't look like powershell syntax to me
Member
Author
There was a problem hiding this comment.
echo and ls definitely work under a powershell shell, they are just aliases (the .FullName part is the giveaway for powershell). Mostly this was to get the path to the files in the Windows format.
If you prefer I can change them to their non-aliased version; it was mostly for the reduced verbosity to me.
Member
There was a problem hiding this comment.
It was the $() I wasn't sure of
directionless
approved these changes
Oct 23, 2024
| working-directory: ${{ steps.build_paths.outputs.PACKAGE_BUILD }} | ||
| id: packages | ||
| shell: bash | ||
| shell: powershell |
Member
There was a problem hiding this comment.
It was the $() I wasn't sure of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packaging logic expects to enter into a specific folder to create Windows packages inside.
This folder was not being created and the workflow was not complaining for its absence, using the root of the workspace.
Add the folder as it exists for the other jobs.