Extend timeout for test HTTP server #8445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some CI runs (eg. https://github.com/osquery/osquery/actions/runs/11383780628/job/31688077319?pr=8421) the server seems to shut down before the test completes. This is intended to improve reliability by increasing the timeout.
Smjert
previously approved these changes
Oct 17, 2024
Member
Author
|
30 seconds does not appear to be long enough: https://github.com/osquery/osquery/actions/runs/11390707801/job/31692924542?pr=8445#step:19:2899 Side note, I don't understand why these tests have just become so flakey... |
Member
|
At this point I'm not sure this is a timeout issue; looking at the messages I don't see the message of the python server starting, even though it does give the message of the timeout. This is quite weird. Looking at older logs one should be able to see: Which means that the osquery test found that port 22712 is free, so it can start the python server. But in the logs of this PR that Starting message did not appear |
directionless
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some CI runs (eg. https://github.com/osquery/osquery/actions/runs/11383780628/job/31670155405?pr=8421#step:19:2925) the server seems to shut down before the test completes. This is intended to improve reliability by increasing the timeout.