Add additional WMI data to deviceguard_status table
#8440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Friendly ping for a reviewer :) |
deviceguard_status table
|
|
||
| std::vector<long> running_security_services; | ||
| data.GetVectorOfLongs("SecurityServicesRunning", running_security_services); | ||
| for (int i = 0; i < running_security_services.size(); i++) { |
Member
There was a problem hiding this comment.
Why not boost::algorithm::join?
Contributor
Author
There was a problem hiding this comment.
Would it actually be better in this case? We still have to iterate over the list and do a comparison to convert the integers to string values before adding them to the list, and this roughly matches the style done here previously. Granted I'm not a c++ expert and have little familiarity with boost, so if there's a fancy way to combine the conversion and concatenation I'm open to the idea.
Member
There was a problem hiding this comment.
I don't know. I guess if we have to the comparison anyhow, there's no win using a join :|
directionless
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change imports the remaining useful fields presented by the
Win32_DeviceGuardWMI table.