Skip to content

Fix: safari_extensions not returning results #8427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
directionless merged 1 commit into from
Oct 8, 2024
Merged

Fix: safari_extensions not returning results #8427

directionless merged 1 commit into from
Oct 8, 2024

Conversation

@Smjert
Copy link
Member

@Smjert Smjert commented Sep 23, 2024 •
edited
Loading

We want to have the extension identifier be present in the Extensions.plist, not the opposite.

With a couple of test extensions:

osquery> select * from safari_extensions;
           uid = 501
          name = Safari Extension
    identifier = com.1password.safari.extension
       version = 8.10.46
           sdk = 6.0
    update_url =
        author =
  developer_id =
   description =
          path = /Applications/1Password for Safari.app/Contents/PlugIns/%.appex/Contents/Info.plist
bundle_version = 81046034
     copyright =
extension_type = WebOrAppExtension

           uid = 501
          name = Ghostery Privacy Ad Blocker Extension
    identifier = com.ghostery.extension.safari
       version = 10.4.6
           sdk = 6.0
    update_url =
        author =
  developer_id =
   description =
          path = /Applications/Ghostery Privacy Ad Blocker.app/Contents/PlugIns/%.appex/Contents/Info.plist
bundle_version = 29
     copyright =
extension_type = WebOrAppExtension

@Smjert
fix: Fix safari_extensions not returning results
72f13e2 
We want to have the extension identifier be present
in the Extensions.plist, not the opposite.
@Smjert Smjert requested review from a team as code owners September 23, 2024 19:35
@directionless directionless changed the title fix: Fix safari_extensions not returning results Fix: safari_extensions not returning results Oct 8, 2024
@directionless directionless merged commit b154489 into osquery:master Oct 8, 2024
@Smjert Smjert deleted the stefano/fix/safari-extensions branch October 8, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@directionless directionless directionless approved these changes

Assignees

No one assigned

Labels

bug macOS virtual tables

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Smjert @directionless