build: Cleanups and fixes for a newer clang toolchain #8412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Force the use of the DWARF debug symbols version 4, since only very recent versions of gdb support any version higher than that and on newer clang versions, 5 is the default. - Correct the secure_getenv check; GLIBC 2.17 is the first version that adds supports for it, so it should be included - Move the selection of the standard library implementation and corollary library on Linux to be a toolchain specific setting, making it slightly easier to build with a different toolchain.
directionless
approved these changes
Sep 6, 2024
Member
Author
|
Refreshing to get CI workflow updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the use of the DWARF debug symbols version 4, since only very recent versions of gdb support any version higher than that and on newer clang versions, 5 is the default.
Correct the secure_getenv check; GLIBC 2.17 is the first version that adds supports for it, so it should be included
Move the selection of the standard library implementation and corollary library on Linux to be a toolchain specific setting, making it slightly easier to build with a different toolchain.