Skip to content

Align ES functions with documented macOS versions #8338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwass merged 1 commit into from
Feb 19, 2025
Merged

Align ES functions with documented macOS versions #8338

zwass merged 1 commit into from
Feb 19, 2025

Conversation

@SilverPlate3
Copy link
Contributor

@SilverPlate3 SilverPlate3 commented May 28, 2024

Per the docs es_mute_path_literal and es_mute_path_prefix are deprecated since MacOS 12.0
And es_mute_path is available since 12.0.
So Code needs to align with docs.

es_mute_path_literal
image
es_mute_path_prefix
image

es_mute_path
image

@SilverPlate3 SilverPlate3 requested review from a team as code owners May 28, 2024 18:44
@directionless directionless changed the title Align MacOs version with docs Align ES functions with documented macOs versions May 28, 2024
@SilverPlate3
Copy link
Contributor Author

SilverPlate3 commented Jun 3, 2024

Hey @directionless @sharvilshah
When can I expect this to be pushed?
Thanks guys

@directionless
Copy link
Member

directionless commented Jun 3, 2024

When can I expect this to be pushed? Thanks guys

I expect we'll cut a release this month, and this should land in that.

@directionless directionless added this to the 5.13 milestone Jun 3, 2024
@sharvilshah
Copy link
Member

sharvilshah commented Jun 4, 2024

hi @SilverPlate3! thanks so much for this!

I am currently testing this with older macOS versions/SDK, I recall that there was a mismatch with apple's documentation and behavior of this api at the time, and I don't want to break things for folks on older versions. But as @directionless mentioned, this should make this cut for 5.13 release.

@michael-myers michael-myers changed the title Align ES functions with documented macOs versions Align ES functions with documented macOS versions Jul 2, 2024
@directionless directionless removed this from the 5.13 milestone Jul 6, 2024
@zwass
Copy link
Member

zwass commented Dec 24, 2024

@sharvilshah does this require further testing?

zwass
zwass approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as it matches the documentation and passes CI. Thanks for the contribution @SilverPlate3 and sorry for the delay in merging this!

@zwass zwass merged commit 1171cd0 into osquery:master Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwass zwass zwass approved these changes

Assignees

@sharvilshah sharvilshah

Labels

macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SilverPlate3 @directionless @sharvilshah @zwass