Skip to content

Update user_ssh_keys with additional details for OpenSSL-style keys #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
directionless merged 2 commits into from
Jun 20, 2024
Merged

Update user_ssh_keys with additional details for OpenSSL-style keys #8314

directionless merged 2 commits into from
Jun 20, 2024

Conversation

@kcreyts
Copy link
Contributor

@kcreyts kcreyts commented Apr 22, 2024 •
edited
Loading

This PR introduces additional columns which use OpenSSL macros to get additional details about PEM keys in user .ssh/ directories.

  • "key_length" uses OpenSSL's EVP_PKEY_bits to get the cryptographic length of the cryptosystem to which the private key belongs, in bits. Definition of cryptographic length is specific to cryptosystem.
  • "key_security_bits" uses OpenSSL's EVP_PKEY_security_bits to get the number of security bits of the given key (bits of security as defined in NIST SP800-57).
  • "key_group_name" uses OpenSSL's EVP_PKEY_get_group_name to get the group of the private key. Supported for a subset of key_types implemented by OpenSSL.

@kcreyts kcreyts requested review from a team as code owners April 22, 2024 21:51
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@kcreyts kcreyts force-pushed the add-ssh-key-length branch from 824c9f1 to be21a7d Compare April 22, 2024 21:58
@kcreyts kcreyts force-pushed the add-ssh-key-length branch from be21a7d to 0939c0e Compare April 22, 2024 22:02
directionless
directionless reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple, nice. Can you add this to the table integration tests?

@kcreyts kcreyts requested review from Smjert and directionless April 25, 2024 00:17
@kcreyts
Copy link
Contributor Author

kcreyts commented Apr 25, 2024

extended integration testing.

directionless
directionless approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. Thank you so much!

@directionless directionless added this to the 5.13 milestone May 1, 2024
@directionless directionless merged commit 4e144cc into osquery:master Jun 20, 2024
@directionless directionless changed the title add additional details for OpenSSL-style keys Update user_ssh_keys with additional details for OpenSSL-style keys Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@directionless directionless directionless approved these changes

@Smjert Smjert Awaiting requested review from Smjert

Assignees

No one assigned

Labels

virtual tables

Projects

None yet

Milestone

5.13

Development

Successfully merging this pull request may close these issues.

3 participants

@kcreyts @Smjert @directionless