Using std::setprecision to get the right precision for double to string conversion. #8302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
reviewed
May 3, 2024
| std::string operator()(const double& d) const { | ||
| std::string s{boost::lexical_cast<std::string>(d)}; | ||
| std::ostringstream ss; | ||
| ss << std::setprecision(std::numeric_limits<double>::digits10 + 1) << d; |
Contributor
There was a problem hiding this comment.
Is it 16 because that's the case for most doubles?
Double values have between 15 and 18 digits of precision, with most double values having at least 16 significant digits. (source)
Contributor
Author
There was a problem hiding this comment.
SQLite supports 15 significant digits. So we set precision to 15 significant digits plus 1 insignificant (estimate). The previous approach was using more digits, leading to bad results in some cases.
This pattern is used in many other places:
https://github.com/search?q=%22std%3A%3Asetprecision%28std%3A%3Anumeric_limits%3Cdouble%3E%3A%3Adigits10+%2B+1%29%22&type=code
lucasmrod
approved these changes
May 3, 2024
Contributor
lucasmrod
left a comment
There was a problem hiding this comment.
LGTM, left one question.
|
Maybe @directionless , could you review this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8301
boost::lexical_cast was not using the right precision for double-to-string conversion.
Switched to using std::ostringstream.