Handle locale-specific formats on macOS system_profiler output #2890
+146
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some macOS installations have 4 digits years on Last Modified dates of system_profiler SPApplicationsDataType output. This commit includes a fallback to theses scenarios.
Contributor
Author
|
Example of "system_profiler SPApplicationsDataType" output: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
+ Coverage 85.87% 86.92% +1.05%
==========================================
Files 32 32
Lines 1423 1423
Branches 204 204
==========================================
+ Hits 1222 1237 +15
+ Misses 115 107 -8
+ Partials 86 79 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbwiddis
reviewed
May 22, 2025
Member
dbwiddis
left a comment
There was a problem hiding this comment.
Thanks for this PR!
I've suggested an alternative fix. Let me know what you think.
oshi-core/src/main/java/oshi/software/os/mac/MacInstalledApps.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
May 23, 2025
Member
dbwiddis
left a comment
There was a problem hiding this comment.
Looks great! Just a few nits.
oshi-core/src/main/java/oshi/jna/platform/mac/CoreFoundation.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/jna/platform/mac/CoreFoundation.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacInstalledApps.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacInstalledApps.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/software/os/mac/MacInstalledApps.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
May 23, 2025
oshi-core/src/main/java/oshi/jna/platform/mac/CoreFoundation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some macOS installations have 4 digits years on Last Modified dates of system_profiler SPApplicationsDataType output.
This commit uses JNA to get the correct date/time format