Add process specific open file descriptor limits by gitseti · Pull Request #2225 · oshi/oshi

gitseti · 2022-10-26T08:23:37Z

This resolves #2215 as it implements the second needed part.

sonatype-lift · 2022-10-26T08:29:07Z

⚠️ 26 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift · 2022-10-26T08:49:02Z

+    @Override
+    public long getHardOpenFileLimit() {
+        final Resource.Rlimit rlimit = new Resource.Rlimit();
+        OpenBsdLibc.INSTANCE.getrlimit(OpenBsdLibc.RLIMIT_NOFILE, rlimit);


💬 15 similar findings have been found in this PR

INTERFACE_NOT_THREAD_SAFE: Unprotected call to method OpenBsdLibc.getrlimit(...) of un-annotated interface oshi.jna.platform.unix.OpenBsdLibc. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because the current class is annotated @ThreadSafe.

🔎 Expand here to view all instances of this finding

File Path Line Number

oshi-core/src/main/java/oshi/software/os/unix/freebsd/FreeBsdOSProcess.java 275

oshi-core/src/main/java/oshi/software/os/unix/freebsd/FreeBsdOSProcess.java 287

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 282

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 264

oshi-core/src/main/java/oshi/software/os/mac/MacOSProcess.java 316

oshi-core/src/main/java/oshi/software/os/mac/MacOSProcess.java 328

oshi-core/src/main/java/oshi/software/os/unix/solaris/SolarisOSProcess.java 269

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 270

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 276

oshi-core/src/main/java/oshi/software/os/unix/openbsd/OpenBsdOSProcess.java 311

Showing 10 of 15 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-27T08:23:09Z

        this.majorVersion = major;
        this.minorVersion = minor;
+        this.os = os;
        updateAttributes();


💬 15 similar findings have been found in this PR

INTERFACE_NOT_THREAD_SAFE: Unprotected call to method SystemB.getgrgid(...) of un-annotated interface com.sun.jna.platform.mac.SystemB. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because the current class is annotated @ThreadSafe.

🔎 Expand here to view all instances of this finding

File Path Line Number

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 270

oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java 179

oshi-core/src/main/java/oshi/software/os/unix/openbsd/OpenBsdOSProcess.java 313

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 281

oshi-core/src/main/java/oshi/software/os/mac/MacOSProcess.java 327

oshi-core/src/main/java/oshi/software/os/unix/aix/AixOSProcess.java 252

oshi-core/src/main/java/oshi/software/os/unix/openbsd/OpenBsdOSProcess.java 324

oshi-core/src/main/java/oshi/software/os/mac/MacOSProcess.java 316

oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java 99

oshi-core/src/main/java/oshi/software/os/mac/MacOperatingSystem.java 174

Showing 10 of 15 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

dbwiddis · 2022-10-29T18:20:28Z

Hey @gitseti don't want to rush this PR, but based on a bug report in AIX I'm probably going to try to push out a patch release this weekend. Do you want me to try to wait for you to finish this implementation or is it close enough to release it as-is with some more tweaks for the next version?

gitseti · 2022-10-29T19:55:10Z

Hey @dbwiddis, imo, it should be ready for review now.

The only thing left would be to have a solution for Windows as I'm not sure how to do the _getmaxstdio JNA call.
Currently, we just use the getMaxFileDescriptorsPerProcess returned limits for getSoftOpenFileLimit and getHardOpenFileLimit on Windows. We can also deliver the more precise limits for Windows in a later patch.
WDYT?

dbwiddis · 2022-10-30T02:02:42Z

We can table the windows _getmaxstdio question. I think it actually only applies to the Windows C runtime so would be inaccurate for other processes. I replaced your call navigating the API to get to a constant with a direct fetching of the constant (which happens to be in a class in the same package). Will merge shortly.

Thanks again for your contribution!

gitseti force-pushed the process-specific-open-file-limits branch from 402c06c to e708de8 Compare October 26, 2022 08:24

gitseti force-pushed the process-specific-open-file-limits branch 2 times, most recently from 7d625ae to 98c2af6 Compare October 26, 2022 08:33

Add process specific open file descriptor limits

a36fff9

gitseti force-pushed the process-specific-open-file-limits branch from 98c2af6 to a36fff9 Compare October 26, 2022 08:43

sonatype-lift Bot reviewed Oct 26, 2022

View reviewed changes

dbwiddis reviewed Oct 27, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/software/os/OSProcess.java Outdated

gitseti added 2 commits October 27, 2022 10:17

Merge process specific open file limit methods

a948bc8

Clarify javadoc

1b4f80e

sonatype-lift Bot reviewed Oct 27, 2022

View reviewed changes

gitseti and others added 3 commits October 27, 2022 10:23

Cleanup comments

c5d4e3e

CR > Remove os object creation

d65d5bb

CR > Remove unused imports

6272d5d

gitseti marked this pull request as ready for review October 29, 2022 19:55

Return MAX_WINDOWS_HANDLES directly

ae43989

dbwiddis added the hacktoberfest Issues we're happy for new #Hacktoberfest2020 participants to do label Oct 30, 2022

dbwiddis merged commit 8970dfc into oshi:master Oct 30, 2022

dbwiddis mentioned this pull request May 23, 2026

Audit and test OSProcess open file limit implementations #3286

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add process specific open file descriptor limits#2225

Add process specific open file descriptor limits#2225
dbwiddis merged 7 commits into
oshi:masterfrom
gitseti:process-specific-open-file-limits

gitseti commented Oct 26, 2022 •

edited

Loading

Uh oh!

sonatype-lift Bot commented Oct 26, 2022

Uh oh!

sonatype-lift Bot Oct 26, 2022

Uh oh!

Uh oh!

sonatype-lift Bot Oct 27, 2022

Uh oh!

dbwiddis commented Oct 29, 2022

Uh oh!

gitseti commented Oct 29, 2022 •

edited

Loading

Uh oh!

dbwiddis commented Oct 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

File Path	Line Number
oshi-core/src/main/java/oshi/software/os/unix/freebsd/FreeBsdOSProcess.java	275
oshi-core/src/main/java/oshi/software/os/unix/freebsd/FreeBsdOSProcess.java	287
oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java	282
oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java	264
oshi-core/src/main/java/oshi/software/os/mac/MacOSProcess.java	316
oshi-core/src/main/java/oshi/software/os/mac/MacOSProcess.java	328
oshi-core/src/main/java/oshi/software/os/unix/solaris/SolarisOSProcess.java	269
oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java	270
oshi-core/src/main/java/oshi/software/os/linux/LinuxOSProcess.java	276
oshi-core/src/main/java/oshi/software/os/unix/openbsd/OpenBsdOSProcess.java	311

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Uh oh!

Conversation

gitseti commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonatype-lift Bot commented Oct 26, 2022

Uh oh!

sonatype-lift Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonatype-lift Bot Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

dbwiddis commented Oct 29, 2022

Uh oh!

gitseti commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbwiddis commented Oct 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gitseti commented Oct 26, 2022 •

edited

Loading

gitseti commented Oct 29, 2022 •

edited

Loading