Merged
Conversation
ondrejbudai
reviewed
Feb 3, 2024
achilleas-k
reviewed
Feb 3, 2024
466a4e7 to
ad26559
Compare
mvo5
previously approved these changes
Feb 5, 2024
Contributor
mvo5
left a comment
There was a problem hiding this comment.
This looks super nice and I like the principles. I some nitpicks inline but I think they are not very important, we could merge this as is and just followup or discuss here a bit more, either way works for me :)
supakeen
previously approved these changes
Feb 5, 2024
Member
supakeen
left a comment
There was a problem hiding this comment.
Awesome, I'll not start the discussion on the capitalization of osbuild vs OSBuild vs OSbuild in this PR :>
supakeen
reviewed
Feb 5, 2024
dustymabe
reviewed
Feb 6, 2024
dustymabe
reviewed
Feb 9, 2024
dustymabe
approved these changes
Feb 9, 2024
Contributor
dustymabe
left a comment
There was a problem hiding this comment.
I'm not an official OSBuild developer so my vote doesn't count much, but LGTM anyway.
teg
approved these changes
Feb 9, 2024
ondrejbudai
approved these changes
Feb 9, 2024
supakeen
approved these changes
Feb 9, 2024
achilleas-k
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the OSBuild principles based on our discussion and agreement. I have reformulated some sentences for clarity.