osbuild: add pipeline name to monitor status#1885
Merged
supakeen merged 1 commit intoosbuild:mainfrom Sep 19, 2025
Merged
Conversation
mvo5
reviewed
Sep 19, 2025
| break | ||
| } | ||
|
|
||
| assert.NotEmpty(t, st.Pipeline) |
Contributor
There was a problem hiding this comment.
I would prefer if the test would be a bit more specific, maybe we can collect all pipeline names and do a assert.Equal(t, []string{"build", "sources", ...) here, wdyt?
Contributor
Author
There was a problem hiding this comment.
Great idea, amended comparison of compacted slice.
In order to print reasonable duration statistics, we need to know which pipeline is currently running. The osbuild monitor JSON status messages now include the pipeline name in the context object. Without this, one could not tell if the slowest stage was RPM in os or build pipeline. It also adds a testdata that is a complete and unmodified osbuild of a Fedora 42 raw image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to print reasonable duration statistics, we need to know which pipeline is currently running. The osbuild monitor JSON status messages now include the pipeline name in the context object. Without this, one could not tell if the slowest stage was RPM in os or build pipeline.
It also adds a testdata that is a complete and unmodified osbuild of a Fedora 42 raw image.
osbuild/osbuild#2196
HMS-9311