main: provide --preview to toggle preview state (HMS-9969)#449
Merged
achilleas-k merged 1 commit intoosbuild:mainfrom Feb 6, 2026
Merged
main: provide --preview to toggle preview state (HMS-9969)#449achilleas-k merged 1 commit intoosbuild:mainfrom
--preview to toggle preview state (HMS-9969)#449achilleas-k merged 1 commit intoosbuild:mainfrom
Conversation
Certain image types have the notion of being in a preview state. Also called "final", "supported", or "prerelease". In `images`'s distribution definitions we define this flag per version of a distribution. This means that we need to quickly do releases to update this value before a release candidate is built (release candidates are built as "supported"). When pungi schedules composes it knows the supported state of the compose. Thus it is a good idea to let the preview state of a distro be overridden by the `pungi` -> `koji` -> `image-builder` chain. Let's include a `--preview` argument. When the option is not passed at all we let `images` determine the preview state (based on its distribution definitions). When the option is passed we pass along its value to `images` where it is then used instead of the default. I've kept the option hidden here because it really only should be used by build systems or advanced users (we might document its use) and not confuse normal users; who would usually receive new distribution definitions with the next `image-builder` release which contain the correct preview state, though it will lag a bit in time. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
achilleas-k
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #448.
I thought a bit about naming the option in a specific way that would indicate that this is an image option; however, we don't do so for other things that get passed as image options and I don't foresee this name clashing with anything else.
After this is done follow-up work is necessary in
koji-image-builderandpungiitself to be able to pass this argument along.Examples: