go.mod: bump osbuild/images to v0.236.0 (HMS-10105)#441
Merged
thozza merged 5 commits intoosbuild:mainfrom Feb 5, 2026
Merged
Conversation
lzap
previously approved these changes
Jan 26, 2026
Member
|
Failing on empty depsolve results. |
Contributor
Just for the record, I realized that the error handling code simply hides the root cause, very likely the utility now returns non-zero code and this is swallowed. I filed a patch this week to fix this: osbuild/images#2156 |
Contributor
|
Rebased, removed the struct tag, fixed tests. |
Member
Author
|
Note that the problem with this PR is that the test case uses |
1e13387 to
b186389
Compare
The osbuild packages installed from Fedora repositories may be too old to work correctly with the vendored osbuild/images library. This can cause tests to fail with cryptic errors when the images library requires features from a newer osbuild version. This commit adds two scripts and a Schutzfile to handle this: - test/scripts/setup-osbuild-repo: Sets up a dnf repository pointing to pre-built osbuild RPMs from the osbuild CI S3 bucket when a specific commit is pinned in Schutzfile. This allows using newer osbuild versions than what's available in Fedora. - test/scripts/check-osbuild-version: Verifies that installed osbuild and osbuild-depsolve-dnf packages meet the minimum version requirement specified by the vendored osbuild/images library. When bumping the osbuild/images version, if the Fedora osbuild package is too old, one can pin a compatible osbuild commit in Schutzfile to unblock CI. This is consistent with what we do in other repositories. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This bumps the osbuild/images to the version that uses depsolver V2
API.
Also bump the minimum required osbuild version and pin it in the
Schutzfile.
Changes with 0.235.0
----------------
- Align the bootc distro package with the generic one (#2136)
- Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza
- Ensure pinned osbuild version is used consistently in CI and build command. (HMS-10070) (#2145)
- Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Simon de Vlieger
- GHA: bump used golangci-lint version to 2.8 (HMS-10069) (#2144)
- Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Lukáš Zapletal
- Update osbuild dependency commit ID (#2141)
- Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza
- Use the correct libvirt pool instead of hardcoded default (#2147)
- Author: Jakub Kadlčík, Reviewers: Achilleas Koutsou, Simon de Vlieger
- boot-image: add make_check_host_config to boot-aws (#2143)
- Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza
- osbuild: add force option to org.osbuild.groups and always enable [HMS-9825] (#2146)
- Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Lukáš Zapletal, Tomáš Hozza
— Somewhere on the Internet, 2026-01-26
---
Changes with 0.236.0
----------------
- Add V2 depsolver API support and make it the default (HMS-10029) (#2139)
- Author: Tomáš Hozza, Reviewers: Lukáš Zapletal, Simon de Vlieger
— Somewhere on the Internet, 2026-01-26
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Member
|
Integration tests ran out of disk space; linters are unhappy about the osbuild version verification script. |
Member
Author
I know, I know... I'm on it... 🫡 |
Add a shared osbuild store directory mounted into the test containers. This reduces disk usage and speeds up builds by caching RPMs and intermediate artifacts between test runs, consistent with how the BIB tests handle storage. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The minimal-raw image type for centos-9 has a /boot partition that is too small (600 MiB) to fit the kernel, initramfs, and rescue initramfs. The upstream bug is: osbuild/images#2176 With the sharing of osbuild store across builds, it makes even more sense to build the same image type in all tests. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
supakeen
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the osbuild/images to the version that uses depsolver V2 API.
Additional changes:
test/scripts/setup-osbuild-repoto configure dnf repository from osbuild CI S3 bucket when a commit is pinnedtest/scripts/check-osbuild-versionto verify installed osbuild packages meet minimum version requirementsSchutzfilefor dependency version pinning configurationminimal-rawtoqcow2to work around upstream /boot partition size bug (osbuild/images#2176)osbuild/images changes
Changes with 0.235.0
— Somewhere on the Internet, 2026-01-26
Changes with 0.236.0
— Somewhere on the Internet, 2026-01-26