cmd: remove bibupload as it was never exposed to the public#405
Merged
mvo5 merged 1 commit intoosbuild:mainfrom Dec 12, 2025
Merged
cmd: remove bibupload as it was never exposed to the public#405mvo5 merged 1 commit intoosbuild:mainfrom
mvo5 merged 1 commit intoosbuild:mainfrom
Conversation
The bibupload command was originally part of bootc-image-builder and when we moved the go code it moved here. But after talking to Ondrej we decided it can be removed because it was never part of the bootc-image-builder container. It is also problematic as we don't have enough information from the image alone how to upload it (i.e. what boot configuration etc). So lets just remove it, *if* (and that is a big if) we ever need it again we can alwas resurrect it from the git history.
lzap
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bibupload command was originally part of bootc-image-builder and when we moved the go code it moved here. But after talking to Ondrej we decided it can be removed because it was never part of the bootc-image-builder container. It is also problematic as we don't have enough information from the image alone how to upload it (i.e. what boot configuration etc). So lets just remove it, if (and that is a big if) we ever need it again we can alwas resurrect it from the git history.