bib: document details about {,bib}cmd{ManifestFromCobra,Build}#402
Merged
lzap merged 1 commit intoosbuild:mainfrom Dec 12, 2025
Merged
bib: document details about {,bib}cmd{ManifestFromCobra,Build}#402lzap merged 1 commit intoosbuild:mainfrom
lzap merged 1 commit intoosbuild:mainfrom
Conversation
The {,bib}CmdBuild and {,bib}ManifestFromCobra functions are
quite similar which raises the question what could be done
to share more code.
This commit documents the differences and why its hard to
consolidate them. Note that if we would add support for
anaconda-iso into bib via something like:
https://github.com/osbuild/image-builder-cli/compare/main...mvo5:consolidate-bib-anaconda-iso-wip?expand=1
we could remove some of this duplication, however this would
make the "generic" code a bit less nice (trade-offs!).
But other differences like the lack of renaming of the produced
results or the multi-export builds in bib are harder to
consolidate and probably not worth it (i.e. the generic code
becomes more ugly than the de-duplication niceness wins).
45047da to
0ff7e3a
Compare
supakeen
approved these changes
Dec 12, 2025
lzap
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The {,bib}CmdBuild and {,bib}ManifestFromCobra functions are
quite similar which raises the question what could be done
to share more code.
This commit documents the differences and why its hard to
consolidate them. Note that if we would add support for
anaconda-iso into bib via something like:
https://github.com/osbuild/image-builder-cli/compare/main...mvo5:consolidate-bib-anaconda-iso-wip?expand=1
we could remove some of this duplication, however this would
make the "generic" code a bit less nice (trade-offs!).
But other differences like the lack of renaming of the produced
results or the multi-export builds in bib are harder to
consolidate and probably not worth it (i.e. the generic code
becomes more ugly than the de-duplication niceness wins).