main: error when image-builder is used to create anaconda-iso#401
Merged
mvo5 merged 1 commit intoosbuild:mainfrom Dec 12, 2025
Merged
main: error when image-builder is used to create anaconda-iso#401mvo5 merged 1 commit intoosbuild:mainfrom
mvo5 merged 1 commit intoosbuild:mainfrom
Conversation
thozza
previously approved these changes
Dec 11, 2025
The behavior of anaconda-iso without specil mTLS setup is different from bib so instead of introducing subtle incompatibilities just error. Note that we could support this with something like: https://github.com/osbuild/image-builder-cli/compare/main...mvo5:consolidate-bib-anaconda-iso-wip?expand=1 but the general code that is currently fairly nice becomes not so nice anymore as we need to add a bunch of extra things like extracting mTLS, cleanup etc for an image-type we consider legacy and want to replace with the `bootc-installer` image type.
76f5f0a to
03d2a5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior of anaconda-iso without specil mTLS setup is different from bib so instead of introducing subtle incompatibilities just error.
Note that we could support this with something like: https://github.com/osbuild/image-builder-cli/compare/main...mvo5:consolidate-bib-anaconda-iso-wip?expand=1 but the general code that is currently fairly nice becomes not so nice anymore as we need to add a bunch of extra things like extracting mTLS, cleanup etc for an image-type we consider legacy and want to replace with the
bootc-installerimage type.