main: add {supported,required} bp options to describe-image#376
Merged
supakeen merged 1 commit intoosbuild:mainfrom Dec 2, 2025
Merged
main: add {supported,required} bp options to describe-image#376supakeen merged 1 commit intoosbuild:mainfrom
{supported,required} bp options to describe-image#376supakeen merged 1 commit intoosbuild:mainfrom
Conversation
supakeen
reviewed
Nov 21, 2025
cmd/image-builder/describeimg.go
Outdated
| PartitionTable *disk.PartitionTable `yaml:"partition_table,omitempty"` | ||
|
|
||
| SupportedBpOptions []string `yaml:"supported_blueprint_options,omitempty"` | ||
| RequiredBpOptions []string `yaml:"required_blueprint_options,omitempty"` |
Member
There was a problem hiding this comment.
Going to nitpick this but why not write out Blueprint.
A real question: should this be:
blueprint:
required:
- x
supported:
- x
Contributor
Author
There was a problem hiding this comment.
I like this! If we change it here we should also change it in the distrodefs YAML though so that we are symmetrical. Ideally (and that is a kinda big dream) the output of describe-image could be used as the basis for our yaml image definitions so staying close should be our goal.
Member
There was a problem hiding this comment.
Yea this should be our goal. We can do it here first and I'll take care of doing the same in the distro yamls later on :)
Member
There was a problem hiding this comment.
I like the grouping. Let's do it.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Dec 1, 2025
This commit moves the `blueprint_{supported,required}_options`
into a new nested structure:
```yaml
blueprint:
supported_options:
- ...
required_options:
- ...
```
this was suggested for `image-builder describe-image` in:
osbuild/image-builder-cli#376 (comment)
but we need to start here to keep things symetric.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Dec 1, 2025
This commit moves the `blueprint_{supported,required}_options`
into a new nested structure:
```yaml
blueprint:
supported_options:
- ...
required_options:
- ...
```
this was suggested for `image-builder describe-image` in:
osbuild/image-builder-cli#376 (comment)
but we need to start here to keep things symetric.
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Dec 1, 2025
This commit moves the `blueprint_{supported,required}_options`
into a new nested structure:
```yaml
blueprint:
supported_options:
- ...
required_options:
- ...
```
this was suggested for `image-builder describe-image` in:
osbuild/image-builder-cli#376 (comment)
but we need to start here to keep things symetric.
We have the `blueprint:\n {supported,required}_options` in our
YAML for a while now, so high time to expose it via describe-image
as its really useful.
Thanks to Tom for suggesting this!
4b9e495 to
beae728
Compare
lzap
approved these changes
Dec 2, 2025
supakeen
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the
{supported,required}_blueprint_optionsin our YAML for a while now, so high time to expose it via describe-image as its really useful.Thanks to Tom for suggesting this!