Containerfile: copy the entire "." dir into /build#588
Merged
achilleas-k merged 2 commits intoosbuild:mainfrom Aug 8, 2024
Merged
Containerfile: copy the entire "." dir into /build#588achilleas-k merged 2 commits intoosbuild:mainfrom
achilleas-k merged 2 commits intoosbuild:mainfrom
Conversation
achilleas-k
previously approved these changes
Aug 5, 2024
achilleas-k
approved these changes
Aug 6, 2024
Member
achilleas-k
left a comment
There was a problem hiding this comment.
LGTM. Tiny git history comment, but good to go.
Contributor
Author
|
Hrm, this will need #596 first |
When tmt runs it will create a build from a non-git directory. This was breaking the tests and code `test_bib_version`. This commit makes it more robust by ensuring that `unkown` is printed when `bib` was build from a non-git directory.
When `tmt` runs it will not include the `.git` dir when it prepares the source. This was breaking the tmt tests. This commit just makes the containerfile copy the entire current working dir so that we get `.git` if it's there or it is skipped otherwise. Closes: osbuild#583
achilleas-k
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
tmtruns it will not include the.gitdir when it preparesthe source. This was breaking the tmt tests. This commit just makes
the containerfile copy the entire current working dir so that we
get
.gitif it's there or it is skipped otherwise.Closes: #583