Skip to content

test: ensures right bootc ref after anaconda-iso install ran#1169

Closed
mvo5 wants to merge 1 commit intoosbuild:mainfrom
mvo5:test-container-ref-in-anaconda-iso-installer-too
Closed

test: ensures right bootc ref after anaconda-iso install ran#1169
mvo5 wants to merge 1 commit intoosbuild:mainfrom
mvo5:test-container-ref-in-anaconda-iso-installer-too

Conversation

@mvo5
Copy link
Contributor

@mvo5 mvo5 commented Dec 15, 2025 •
edited
Loading

Our "bootc-installer" image installer checks that after the install bootc status points to the right image. This check is missing currently in the anaconda-iso installer type.

Lets make sure we have it too.

This needs bootc-dev/bootc#1851 to be available.

@mvo5 mvo5 requested a review from a team as a code owner December 15, 2025 15:45
@mvo5 mvo5 requested review from achilleas-k, bcl and thozza and removed request for a team December 15, 2025 15:45
@mvo5
test: ensures right bootc ref after anaconda-iso install ran
3622c4a 
Our "bootc-installer" image installer checks that after the
install bootc status points to the right image. This check
is missing currently in the anaconda-iso installer type.

Lets make sure we have it too.
@mvo5 mvo5 force-pushed the test-container-ref-in-anaconda-iso-installer-too branch from d44b4b2 to 3622c4a Compare December 15, 2025 15:56
@mvo5 mvo5 mentioned this pull request Dec 15, 2025
Closed
bcl
bcl approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, rerunning failed test in hopes the bootc change has percolated up to the quay.io container...

@achilleas-k

This comment was marked as outdated.

Sign in to view
@achilleas-k achilleas-k self-assigned this Jan 8, 2026
@achilleas-k
Copy link
Member

achilleas-k commented Jan 8, 2026 

2026-01-06T20:03:59.4840239Z E               assert 'image: quay.io/centos-bootc/centos-bootc:stream9' in "apiVersion: org.containers.bootc/v1
kind: BootcHost
metadata:
  name: host
spec:
  image:
    image: /run/install/repo/container
    transport: oci
  bootOrder: default
status:
  staged: null
  booted:
    image:
      image:
        image: /run/install/repo/container
        transport: oci
      version: '9'
      timestamp: 2026-01-04T06:57:04Z
      imageDigest: sha256:aa12cd367702c383ddb9fc50294c9398b251872aa16f41a2435bbc5c4dae1843
      architecture: amd64
    cachedUpdate: null
    incompatible: false
    pinned: false
    softRebootCapable: false
    store: ostreeContainer
    ostree:
      stateroot: default
      checksum: a848e3ec108f70b79b7558ff8ce353ce7b18aa095333ce531689283c9ea798c4
      deploySerial: 0
    composefs: null
  rollback: null
  rollbackQueued: false
  type: bootcHost

I think this means the call works now, but the ref isn't set. Instead we get /run/install/repo/container which is clearly a failure.

This is wrong. Sorry.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days.

@github-actions github-actions bot added the Stale Issue or PR with no activity for extended period of time label Feb 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 16, 2026

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcl bcl bcl approved these changes

@achilleas-k achilleas-k Awaiting requested review from achilleas-k achilleas-k is a code owner automatically assigned from osbuild/osbuild-reviewers

@thozza thozza Awaiting requested review from thozza thozza is a code owner automatically assigned from osbuild/osbuild-reviewers

Assignees

@achilleas-k achilleas-k

Labels

Stale Issue or PR with no activity for extended period of time

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvo5 @achilleas-k @bcl