bib: drop inContainerOrUnknown() and use setup.IsContainer()#1111
Closed
mvo5 wants to merge 2 commits intoosbuild:mainfrom
Closed
bib: drop inContainerOrUnknown() and use setup.IsContainer()#1111mvo5 wants to merge 2 commits intoosbuild:mainfrom
inContainerOrUnknown() and use setup.IsContainer()#1111mvo5 wants to merge 2 commits intoosbuild:mainfrom
Conversation
lzap
previously approved these changes
Nov 7, 2025
0020e85 to
d381b46
Compare
Contributor
Author
|
Sorry, had to force push because of conflicts in go.mod |
lzap
previously approved these changes
Nov 10, 2025
thozza
previously approved these changes
Nov 10, 2025
achilleas-k
previously approved these changes
Nov 11, 2025
d381b46 to
437add2
Compare
437add2 to
10ee934
Compare
10ee934 to
b393312
Compare
b393312 to
e4e3753
Compare
d8affc1
e4e3753 to
d8affc1
Compare
We have a shared helper now in ibcli, lets drop duplicated code. Thanks to Ondrej for writing the new (and better) helper.
d8affc1 to
d062105
Compare
achilleas-k
approved these changes
Nov 18, 2025
Contributor
Author
|
This moves over to "ibcli" now that the bib code lives there and I will (re)apply it there. |
auto-merge was automatically disabled
December 8, 2025 08:19
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a shared helper now in ibcli, lets drop duplicated code.
Thanks to Ondrej for writing the new (and better) helper.
C.f. osbuild/image-builder-cli#361