Skip to content

deps: switch yaml libraries#1084

Merged
supakeen merged 1 commit intoosbuild:mainfrom
supakeen:yaml-go-yaml
Oct 31, 2025
Merged

deps: switch yaml libraries#1084
supakeen merged 1 commit intoosbuild:mainfrom
supakeen:yaml-go-yaml

Conversation

@supakeen
Copy link
Member

During a recent chat it was brought up that go.pkg.in/yaml.v3 is unmaintained. The YAML organization forked the unmaintained package and is now updating it. The v3 we use here only receives security fixes while v4 will eventually support new features and more of YAML.

Let's do the easy an uncontroversial swap first as this is a maintained drop-in replacement.

@supakeen supakeen requested a review from a team as a code owner October 27, 2025 12:42
@supakeen supakeen requested review from bcl, croissanne and mvo5 and removed request for a team October 27, 2025 12:42
mvo5
mvo5 previously approved these changes Oct 27, 2025
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achilleas-k
Copy link
Member

Conflict from a dep update.

lzap
lzap previously approved these changes Oct 29, 2025
Copy link
Contributor

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, thanks.

During a recent chat it was brought up that `go.pkg.in/yaml.v3` is
unmaintained. The YAML organization forked the unmaintained package and
is now updating it. The `v3` we use here only receives security fixes
while `v4` will eventually support new features and more of YAML.

Let's do the easy an uncontroversial swap first as this is a maintained
drop-in replacement.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
@supakeen supakeen dismissed stale reviews from lzap and mvo5 via 834c40a October 30, 2025 10:50
@supakeen
Copy link
Member Author

Rebased for conflict.

@supakeen supakeen added this pull request to the merge queue Oct 31, 2025
Merged via the queue into osbuild:main with commit bdf32f4 Oct 31, 2025
21 of 22 checks passed
@supakeen supakeen deleted the yaml-go-yaml branch October 31, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants