Improve prefix parsing and ambiguous prefix handling #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@kennylevinsen could you try this branch and let me know if it fixes #247? |
Owner
Author
|
We should add a new variant |
837a397 to
f9d981b
Compare
f9d981b to
a1451dd
Compare
This was referenced Sep 11, 2020
Previously when we see an ambiguous prefix (e.g. "localhost") we'd assume server. We now have a prefix variant `Ambiguous` for such cases and resolving the ambiguity is left to the caller. When there's an ambiguity we try to do the reasonable thing depending on the type of the message: - When the message is a numeric reply we assume server. - In all other cases (e.g. in JOIN/PART/QUIT/PRIVMSG) we assume nick. Other changes: - Removed wildcard patterns to make the code future-proof. - Refactored some logging and comments. Fixes #247
a1451dd to
4b0fea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we see an ambiguous prefix (e.g. "localhost") we'd assume
server. We now have a prefix variant
Ambiguousfor such cases and resolvingthe ambiguity is left to the caller.
When there's an ambiguity we try to do the reasonable thing depending on the
type of the message:
Other changes:
Fixes #247