Skip to content

Fallback to prefix for server name parsing of RPL_YOURHOST reply #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
osa1 merged 4 commits into from
Sep 4, 2020
Merged

Fallback to prefix for server name parsing of RPL_YOURHOST reply #244

osa1 merged 4 commits into from
Sep 4, 2020

Conversation

@trevarj
Copy link
Contributor

@trevarj trevarj commented Sep 4, 2020

Falling back to getting the server name from the prefix, since some IRC servers don't comply with the standard.

Recommended by https://www.irc.com/dev/docs/refs/numerics/002.html

The <servername> may also include other information depending on the server software, for example irc.example.com[203.0.113.15/6667], so we instead recommend relying on the prefix or the RPL_MYINFO (004) numeric if knowing the current server hostname is desired.

Closes #239

osa1
osa1 reviewed Sep 4, 2020
View reviewed changes
@osa1
Copy link
Owner

osa1 commented Sep 4, 2020

Thanks @trevarj . I added two more tests. Will merge when CI finishes.

@osa1 osa1 merged commit cbaf514 into osa1:master Sep 4, 2020
@trevarj trevarj deleted the rpl_yourhost branch September 4, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osa1 osa1 osa1 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't rely on RPL_YOURHOST parsing for connectivity checking

2 participants

@trevarj @osa1