Fixed join/part line modification panic #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple users join/part from a channel at the same timestamp, the line gets modified. This wasn't invalidating the height calulation so it was causing an overflow if many people join/part or if your screen is small and it needs to wrap that line after modification.
trevarj
commented
Jul 1, 2020
osa1
reviewed
Jul 1, 2020
Owner
|
LGTM, thanks @trevarj ! Added one inline question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple users join/part from a channel at the same timestamp, the line gets modified. This wasn't invalidating the height calulation so it was causing an overflow if many people join/part or if your screen is small and it needs to wrap that line after modification.
Ugh, basically what I did for a fix is just add a way to force invalidating the height of the line when it's modified. Didn't think about this when I added
LineDataCachefor height calculation.Closes #227