Added optional config to limit the number of messages in each tab. #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevarj
commented
Jun 25, 2020
dontlaugh
reviewed
Jun 25, 2020
|
A couple of nits from me. I'll let people more familiar with the code comment. Thanks for jumping on this! My server admin thanks you! 👍 |
trevarj
commented
Jun 25, 2020
osa1
approved these changes
Jun 25, 2020
Owner
osa1
left a comment
There was a problem hiding this comment.
This looks great now, thanks! One last comment and then if you could squash your commits this is ready for landing.
Closes osa1#219. Added check if the max buffer was set to zero Fixed up comments Pull request feedback Initial line buffer capacity fix
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219.