Optional rustls support #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks great, thanks! I don't know why Travis-CI doesn't show build errors next to commit lines now, but this needs a round of Opened an issue for the follow-up work: #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default feature
tls-nativewith the status quo, and a non-default featuretls-rustlswhich uses rustls (with rustls-native-certs to use the platform's native cert store).This also adds a dependency on lazy_static so that the TLS connector is only created once (saves parsing all the certs repeatedly), but lazy_static was already in the dependency tree due to several other packages in the tree depending on it.