When a domain resolves to multiple addrs try all of them #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd just try the first address, failing that we'd just wait 30 seconds and try again. This caused problems when a user can only connect to some of the addresses (e.g. they can't connect to IPv6 but can connect to IPv4, but the first address returned is IPv6). Fixes #144
This was referenced Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd just try the first address, failing that we'd just wait 30 seconds and try again. This caused problems when a user can only connect to some of the addresses (e.g. they can't connect to IPv6 but can connect to IPv4, but the first address returned is IPv6).
Fixes #144