Sending NAMES on a server tab creates new tab for each nick in server #302
Description
Go to a server tab and send NAMES with no parameters, and watch how it opens new tabs for every nick in the response.
I believe it's happening due to the following:
In conn.rs:
// RPL_NAMREPLY: List of users in a channel
else if n == 353 && n_params > 3 {
let chan = ¶ms[2];
let chan_target = MsgTarget::Chan {
serv,
chan: ChanNameRef::new(chan),
};
for nick in params[3].split_whitespace() {
ui.add_nick(wire::drop_nick_prefix(nick), None, &chan_target);
}
}
Here is what one RPL_NAMREPLY looks like:
[2021-01-16 23:21:17] DEBUG [libtiny_client/src/lib.rs:508] parsed msg: Msg { pfx: Some(Server("barjavel.freenode.net")), cmd: Reply { num: 353, params: ["trevarj_", "=", "#freenode", "Yoda ryzen taubi19_ MylesBorins bigua Harry maxalt anderson fn dfgg deni"] } }
Notice the last param (param[3]) has a ton of nicks.