Skip to content

PRIVMSG (when none of target or sender is us) is shown with incorrect sender #278

@osa1

Description

@osa1

I just got this message in Freenode:

Msg {
    pfx: Some(
        User { 
            nick: "e",
            user: "e@freenode/staff/spy.edk"
        }
    ),
    cmd: PRIVMSG {
        target: User("$$*"),
        msg: "...",
        is_notice: true,
        ctcp: None
    }
}

Shown as:

Screenshot_2020-11-30_09-40-48

Here the tab name is right (a PRIVMSG sent to $$*, it looks weird but there's no other way to show this message I think) but sender should be e, not my nick.

I suspect this is introduced with db38123.

We should first start testing this stuff (#273) before making any more changes to showing PRIVMSGs, as the logic is already complex enough.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions