feat: proxy flag for additional cors headers#377
Merged
zepatrik merged 2 commits intoory:masterfrom Sep 26, 2024
Merged
Conversation
zepatrik
approved these changes
Sep 25, 2024
Member
zepatrik
left a comment
There was a problem hiding this comment.
LGTM 👍
Tests should pass now with the upstream changes.
I assume that you tested the feature already locally? As it is not critical, but rather "nice-to-have", I'm fine not having any unit tests for this.
Member
|
Ah the other tests are failing because the secret is not available on your branch. |
alnr
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using non standard headers in proxy requests, it results in error like
With this change you can specify additional headers to allow.
Related Issue or Design Document
#261
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments