feat: allow using ory tunnel/proxy with project ID as well#311
Closed
feat: allow using ory tunnel/proxy with project ID as well#311
Conversation
aeneasr
approved these changes
Jul 4, 2023
Contributor
Author
|
I had to do a small refactor of naming to get access to some of the proxy configs from a different package I also added an interface to the |
Benehiko
commented
Jul 4, 2023
Member
|
https://github.com/ory/cli/actions/runs/5455623971/jobs/9927330763?pr=311 tests fail with compile error |
Contributor
Author
seems to be golangci-lint complaining about something. will update |
Contributor
Author
|
I tried refreshing the snapshots locally with no change using |
0dc5f71 to
fe590fa
Compare
fe590fa to
78fa786
Compare
96c5522 to
83e3ca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
In the documentation we indicate that a user can spin up the tunnel/proxy using the project ID or the project slug.
The project ID is not currently supported and will show the user an error
The tunnel/proxy only takes the
--projectflag and does string manipulation to add the project slug into the ory api string.https://www.ory.sh/docs/getting-started/local-development#local-development
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments