feat(table): keep checked on page change#1548
Merged
mlmoravek merged 18 commits intooruga-ui:developfrom Mar 5, 2026
Merged
Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Member
|
Thanks also for the recording. I found another bug in it: The second page of your modified example should only show two items, not five! :D |
Contributor
Author
|
@mlmoravek I think it's actually better to have a prop/default based toggle for this. I think both use-cases are valid depending on what you're doing. Even on the page I'm building I could see a strong argument for forcing the user to go page by page since the user can't see what's on previous pages. So I think it's good to offer choice rather than choosing one correct path for all implementations. |
# Conflicts: # packages/oruga/src/components/table/examples/checkable.vue
# Conflicts: # packages/docs/components/Table.md
mlmoravek
reviewed
Mar 3, 2026
# Conflicts: # packages/docs/components/Table.md
Contributor
Author
|
@mlmoravek i addressed all your feedback, have another look when you get a sec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-02-18.at.12.51.23.PM.mov
In Oruga's current checked table implementation, checkedRows clears when the user navigates to a new page. This works well for some use-cases, but sometimes you need to persist your selected rows. This PR adds a new
keep-checked-on-page-changeprop so you as a developer can control this behavior. The default remains the same and existing implementations will be unaffected by this change. There is also a new config option to control the default globally.Proposed Changes
keep-checked-on-page-changeprop