feat(dropdown): make before and after slots useable alongside the default slot#1535
Merged
feat(dropdown): make before and after slots useable alongside the default slot#1535
before and after slots useable alongside the default slot#1535Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
before and after slots outside the default slotbefore and after slots useable alongside the default slot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
emptyslotbeforeandafterslots outside the default slot.defaultslot, because the user does not need to know them here.BREAKING CHANGE: The ODropdown 'before' and 'after' slots are no longer encapsulated by the 'default' slot., so they can be used alongside it.
BREAKING CHANGE: Some props got removed from the ODropdown
defaultslot.