feat: restructure options properties and types#1517
Merged
Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
42c5916 to
73ae987
Compare
options properties and types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I refactored the useOptions composable to have a more abstract type interface, which makes it easier to use this composable in different components.
This introduces some breaking changes to the options props for several components.
Proposed Changes
useOptionscomposable and typeshiddenproperty from internal options representation. Components which need that propery have to handle it by its own.optionsproperty type of several components.BREAKING CHANGE: The
optionsproperty type of components with child items has changed. The type got simplified to a more abstract type interface.