Skip to content

iconPack in Table does not propagate into the pagination control #1516

@DruSatori

Description

@DruSatori

Overview of the problem

Oruga version: 0.12.3
Vuejs version: 3.5.22
OS/Browser: Mac Safari, Edge, Chrome

Description

setting the iconPack="fa" on an o-table with pagination enabled ( any version ). The pagination control does not show icons. Inspecting the rendered source shows that the iconPack reverts to the default of 'mdi'. Looking at the TablePagination.vue source, it appears that there is no property to be read in order to pass on the Pagination control resulting in the fallback to the default.

Expected behavior

expectation is that the Pagination control would reflect the iconPack set on the table parent.

Actual behavior

The pagination control works and is displayed without icons (as the mdi default is not present )

Steps to reproduce

  1. install font awesome icons
  2. add an o-table
  3. set the iconPack on the o-table to 'fa' ( or anything other than 'mdi' )
  4. Enable pagination
  5. no icons displayed.

proposed solution

Add an iconPack property to the TablePagination.vue, ensure that it gets passed to the included o-pagination that is used internally, though it may simply be as simple as ensure that the TablePagination control adopts the iconPack syntax instead of the old icon-pack syntax.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions