Fix CMake warning on Windows#392
Merged
MatthijsBurgh merged 1 commit intoorocos:masterfrom Apr 4, 2022
Merged
Conversation
Because the minimum cmake version is set to 3.0.2, we see the following policy warning on Windows:
CMake Warning (dev) at C:/ci/ws/install/share/cmake/pybind11/pybind11Common.cmake:127 (if):
Policy CMP0054 is not set: Only interpret if() arguments as variables or
keywords when unquoted. Run "cmake --help-policy CMP0054" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
Quoted variables like "MSVC" will no longer be dereferenced when the policy
is set to NEW. Since the policy is not set the OLD behavior will be used.
If we want to continue to support older versions of CMake, we should opt into the new behavior to
not break the logic in pybind11Common.cmake. Alternatively, we could increase the miminum cmake
version of this project.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
MatthijsBurgh
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the minimum cmake version is set to 3.0.2, we see the following policy warning on Windows:
If we want to continue to support older versions of CMake, we should opt into the new behavior to
not break the logic in pybind11Common.cmake. Alternatively, we could increase the miminum cmake
version of this project.
For reference, here is the line that is producing the warning:
https://github.com/pybind/pybind11/blob/v2.7.1/tools/pybind11Common.cmake#L127
With the the OLD behavior, I'm pretty sure CMake it will substitute the value of the variable
MSVCinto the expression"MSVC". I think we want the NEW behavior so we're comparing against the string literal "MSVC".