Do not pass generated header to add_library#391
Merged
MatthijsBurgh merged 1 commit intoorocos:masterfrom Apr 2, 2022
Merged
Conversation
Newer versions of cmake (>3.22.1) emit the following warning:
CMake Warning (dev) at src/CMakeLists.txt:69 (ADD_LIBRARY):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
I don't know exactly why passing this generated header triggers the warning,
but passing it to add_library doesn't seem necessary.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
In my experience, that warning comes about when the referenced file doesn't exist. In this case, I think the problem is that |
MatthijsBurgh
approved these changes
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of cmake (>3.22.1) emit the following warning:
CMake Warning (dev) at src/CMakeLists.txt:69 (ADD_LIBRARY):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
I don't know exactly why passing this generated header triggers the warning,
but passing it to add_library doesn't seem necessary.