Make .pc file relocatable and refactor cmake config#255
Merged
Conversation
fix #251) ${pcfiledir} refers to the installed location of the .pc file. Added @LIB_SUFFIX@ to libdir to match install destination in src/CMakeLists.txt. CMake variable KDL_INCLUDE_DIRS was unused.
- Avoid relative paths (../../..) in exported CMake variables - Find dependencies in downstream packages and do not export build-time include directories - Use find_package(Eigen3) CMake config shipped with newer Eigen versions and install custom FindEigen3.cmake to find older versions - Rename CMake templates to match the installed filenames
Collaborator
|
@meyerj PyKDL fails to build because of a issue finding boost. Which tracebacks to |
… config ... if KDL_USE_NEW_TREE_INTERFACE is true.
6a0de1f to
b2cf207
Compare
Member
Author
Should be fixed by b2cf207. Boost is only required in downstream packages if |
MatthijsBurgh
approved these changes
Jun 7, 2020
Collaborator
MatthijsBurgh
left a comment
There was a problem hiding this comment.
@meyerj go ahead and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251:
and also addresses #251 (comment):
Tested in Ubuntu 18.04 with CMake 3.10.2 and also in Ubuntu 12.04 with CMake 2.8.7 (with Eigen
3.0.5-1). In both cases downstream packages findorocos_kdlin relocated installation directories with both, CMake and pkg-config.