Skip to content

Add private constructor for delegating initialization. Fixes #177.#178

Merged
smits merged 1 commit intoorocos:masterfrom
martiniil:fix/path_circle_memory_leak
Mar 4, 2019
Merged

Add private constructor for delegating initialization. Fixes #177.#178
smits merged 1 commit intoorocos:masterfrom
martiniil:fix/path_circle_memory_leak

Conversation

@martiniil
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@smits smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, 👍

@smits
Copy link
Copy Markdown
Member

smits commented Mar 4, 2019

@martiniil I did not notice this broke our build, please check https://travis-ci.org/orocos/orocos_kinematics_dynamics/jobs/499811973

@martiniil
Copy link
Copy Markdown
Contributor Author

@smits Thanks for your approval. Building with c++11 is not an option? Then I would have to think about another way.

@smits
Copy link
Copy Markdown
Member

smits commented Mar 18, 2019

It might be an option, but then we should enforce it in our build to avoid accidental breakage ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants