Skip to content

Zig 0.11 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YellowApple wants to merge 10 commits into from
Closed

Zig 0.11 #8

YellowApple wants to merge 10 commits into from

Conversation

@YellowApple
Copy link

@YellowApple YellowApple commented Apr 18, 2023 •
edited
Loading

Description

Fixes some compilation errors I encountered when building under Zig 0.11.0-dev.2287+1de64dba2. This PR probably ain't ready to merge yet, since there are also some errors in zig-clap that require a separate PR there (and some git submodule shenanigans, probably). zig-clap is already Zig-0.11-ready on master, so that's good to go.

Motivation and Context

This is required to build linuxwave with Zig versions 0.11 and greater.

How Has This Been Tested?

zig version  # outputs 0.11.0-dev.2287+1de64dba2
zig build -Doptimize=ReleaseSafe  # to make sure the build process still works in isolation
zig build test
zig build run -- -s 0,7,1 -n 60 -v 65 -o boss.wav  # and other "presets" from the README

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@YellowApple YellowApple marked this pull request as ready for review April 18, 2023 00:35
@YellowApple YellowApple requested a review from orhun as a code owner April 18, 2023 00:35
@orhun
Copy link
Owner

orhun commented Apr 19, 2023

Hello! 🐻

Thanks for your contribution. However, I'm not sure if switching to Zig master is something that will benefit the project right now. Most of the prominent Linux distros have the latest stable version of Zig (as of 0.10.1) packaged in their repositores and switching to 0.11.0-dev.2287+1de64dba2 will mean that they won't be able to distribute linuxwave. Also, it will make the manual compilation harder for users since they will need the development version of Zig and it might have some quirks in the future.

I will keep this PR open until there is a stable release for 0.11 and we can merge it when the adoption is becoming higher.

kassane
kassane suggested changes Apr 19, 2023
View reviewed changes
kassane
kassane suggested changes Apr 19, 2023
View reviewed changes
Copy link

@kassane kassane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more suggestions

@YellowApple
Copy link
Author

YellowApple commented Apr 19, 2023

Yeah, I definitely don't expect this to be merged before 0.11's actually released; more just documenting the steps I needed to take to get it to build.

@orhun
Copy link
Owner

orhun commented Apr 19, 2023

I see, thank you for making that clear and submitting this PR!

@orhun orhun mentioned this pull request Jul 31, 2023
Closed
@booniepepper
Copy link

booniepepper commented Aug 4, 2023

Zig 0.11.0 is now released! 🎉

@orhun orhun mentioned this pull request Aug 5, 2023
Closed
@orhun
Copy link
Owner

orhun commented Aug 5, 2023

Ping @YellowApple, can you look into this once again?

@orhun orhun mentioned this pull request Aug 18, 2023
Closed
@tranzystorekk tranzystorekk mentioned this pull request Apr 21, 2024
Merged
10 tasks
@orhun
Copy link
Owner

orhun commented Oct 7, 2024

done in #28

thanks for your efforts everyone!

@orhun orhun closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun Awaiting requested review from orhun orhun is a code owner

1 more reviewer

@kassane kassane kassane requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YellowApple @orhun @booniepepper @kassane