fix(install): install in temp path instead of user working dir#51
Merged
orhun merged 3 commits intoorhun:mainfrom Apr 12, 2025
gmeligio:github_action_path
Merged
fix(install): install in temp path instead of user working dir#51orhun merged 3 commits intoorhun:mainfrom gmeligio:github_action_path
orhun merged 3 commits intoorhun:mainfrom
gmeligio:github_action_path
Conversation
orhun
approved these changes
Apr 12, 2025
Owner
orhun
left a comment
There was a problem hiding this comment.
Good catch, thanks!
I'll try to release this along with the new git-cliff version soon.
Contributor
Author
|
Thank you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action is currently installing the artifacts into the user's working dir. This conflicts with further steps, like git commit, that the user might want to do. See the picture below.
The proposed change is to install the artifacts in a temporary directory to solve this. On the other hand, fixed a typo in
ARCHIVE_CMD.