Skip to content

docs(docker): fix typo in comment #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 1 commit into from
Nov 22, 2024
Merged

docs(docker): fix typo in comment #959

orhun merged 1 commit into from
Nov 22, 2024

Conversation

@jmartens
Copy link
Contributor

@jmartens jmartens commented Nov 22, 2024

Description

Small typo fix iin comment in Dockerfile

Motivation and Context

I ❤️ correct spelling

How Has This Been Tested?

N/A

Screenshots / Logs (if applicable)

N/A

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jmartens jmartens requested a review from orhun as a code owner November 22, 2024 06:54
@welcome
Copy link

welcome bot commented Nov 22, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.35%. Comparing base (36ad993) to head (d85c506).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
- Coverage   43.40%   43.35%   -0.05%     
==========================================
  Files          21       21              
  Lines        1712     1712              
==========================================
- Hits          743      742       -1     
- Misses        969      970       +1
Flag Coverage Δ
unit-tests 43.35% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

orhun
orhun approved these changes Nov 22, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@orhun orhun merged commit dbda091 into orhun:main Nov 22, 2024
66 of 67 checks passed
@welcome
Copy link

welcome bot commented Nov 22, 2024

Congrats on merging your first pull request! ⛰️

@jmartens jmartens deleted the patch-1 branch November 22, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmartens @codecov-commenter @orhun