Skip to content

docs(config): correct comment for topo_order_commits in cliff.toml #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 1 commit into from
Dec 7, 2025
Merged

docs(config): correct comment for topo_order_commits in cliff.toml #1314

orhun merged 1 commit into from
Dec 7, 2025

Conversation

@OpenSauce
Copy link
Contributor

@OpenSauce OpenSauce commented Dec 6, 2025 •
edited
Loading

Description

I noticed the comment was incorrect!

Also, thanks for the awesome repo 😄

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.51%. Comparing base (a22a1a3) to head (065f173).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   43.56%   43.51%   -0.04%     
==========================================
  Files          23       23              
  Lines        2241     2241              
==========================================
- Hits          976      975       -1     
- Misses       1265     1266       +1
Flag Coverage Δ
unit-tests 43.51% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OpenSauce OpenSauce changed the title fix: correct comment for topo_order_commits in cliff.toml docs(config): correct comment for topo_order_commits in cliff.toml Dec 6, 2025
@OpenSauce OpenSauce marked this pull request as ready for review December 6, 2025 22:54
@OpenSauce OpenSauce requested a review from orhun as a code owner December 6, 2025 22:54
orhun
orhun approved these changes Dec 7, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@orhun orhun merged commit c8aad00 into orhun:main Dec 7, 2025
94 checks passed
@welcome
Copy link

welcome bot commented Dec 7, 2025

Congrats on merging your first pull request! ⛰️

@BrewTestBot BrewTestBot mentioned this pull request Dec 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OpenSauce @codecov-commenter @orhun