Skip to content

chore: refactor feature flags #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 3 commits into from
Sep 21, 2025
Merged

chore: refactor feature flags #1263

orhun merged 3 commits into from
Sep 21, 2025

Conversation

@tessus
Copy link
Contributor

@tessus tessus commented Sep 20, 2025

Description

adds an intergrations feature flag that includes all integrations.

If this is considered, I will update the docs after #1262 has been merged.

Motivation and Context

see #1261 (comment)

How Has This Been Tested?

manually

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: build process cargo

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner September 20, 2025 16:57
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.31%. Comparing base (20295ac) to head (99299e3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1263   +/-   ##
=======================================
  Coverage   43.31%   43.31%           
=======================================
  Files          22       22           
  Lines        1986     1986           
=======================================
  Hits          860      860           
  Misses       1126     1126
Flag Coverage Δ
unit-tests 43.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tessus
Copy link
Contributor Author

tessus commented Sep 20, 2025

Hmm, weird:

Initialized empty Git repository in /home/runner/work/git-cliff/git-cliff/.github/fixtures/test-gitea-integration/.git/
fatal: unable to access 'https://codeberg.org/ThetaDev/git-cliff-readme-example.git/': Failed to connect to codeberg.org port 443 after 275 ms: Connection refused

orhun
orhun reviewed Sep 20, 2025
View reviewed changes
orhun
orhun reviewed Sep 21, 2025
View reviewed changes
orhun
orhun approved these changes Sep 21, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orhun orhun merged commit 3b98d19 into orhun:main Sep 21, 2025
90 of 91 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tessus @codecov-commenter @orhun