Skip to content

feat: add Nix CI #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 1 commit into from
Nov 6, 2024
Merged

feat: add Nix CI #939

orhun merged 1 commit into from
Nov 6, 2024

Conversation

@blackheaven
Copy link
Contributor

@blackheaven blackheaven commented Oct 29, 2024

Description

Add full Nix build and associated CI.

Motivation and Context

Following my previous Nix PR, I was suggested to add the CI part.

It had took a full Nix build support (instead of just an environment definition.

How Has This Been Tested?

Locally via nix flake check -Lv.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@blackheaven blackheaven requested a review from orhun as a code owner October 29, 2024 19:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.97%. Comparing base (0fabf22) to head (071044d).
Report is 100 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   42.91%   42.97%   +0.06%     
==========================================
  Files          21       21              
  Lines        1713     1713              
==========================================
+ Hits          735      736       +1     
+ Misses        978      977       -1
Flag Coverage Δ
unit-tests 42.97% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

orhun
orhun reviewed Oct 30, 2024
View reviewed changes
orhun
orhun reviewed Nov 6, 2024
View reviewed changes
orhun
orhun approved these changes Nov 6, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@orhun orhun merged commit d0848ff into orhun:main Nov 6, 2024
@blackheaven
Copy link
Contributor Author

blackheaven commented Nov 6, 2024

Thanks for your guidance!

@Moisan Moisan mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blackheaven @codecov-commenter @orhun