Skip to content

feat(nix): add a basic Nix environment #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 2 commits into from
Oct 16, 2024
Merged

feat(nix): add a basic Nix environment #918

orhun merged 2 commits into from
Oct 16, 2024

Conversation

@blackheaven
Copy link
Contributor

@blackheaven blackheaven commented Oct 10, 2024

Description

I add a basic Nix environment.

Motivation and Context

Provide a reproducible dev environment.

How Has This Been Tested?

I've run it on my NixOS.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Add a new dev tool.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@blackheaven blackheaven requested a review from orhun as a code owner October 10, 2024 18:08
@welcome
Copy link

welcome bot commented Oct 10, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.68%. Comparing base (b604883) to head (84d16c0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   41.74%   41.68%   -0.05%     
==========================================
  Files          21       21              
  Lines        1670     1670              
==========================================
- Hits          697      696       -1     
- Misses        973      974       +1
Flag Coverage Δ
unit-tests 41.68% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

orhun
orhun approved these changes Oct 16, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for your contribution!

Would you be also interested in submitting another PR to test the Nix builds in the GitHub Actions CI? (similar to orhun/binsider#75)

@orhun orhun changed the title feat: add basic Nix environment (#743) feat(nix): add a basic Nix environment Oct 16, 2024
@orhun orhun merged commit 6b17736 into orhun:main Oct 16, 2024
@welcome
Copy link

welcome bot commented Oct 16, 2024

Congrats on merging your first pull request! ⛰️

@orhun orhun mentioned this pull request Oct 16, 2024
Closed
1 task
@blackheaven
Copy link
Contributor Author

blackheaven commented Oct 16, 2024

I'll have a look, thanks.

@blackheaven blackheaven mentioned this pull request Oct 29, 2024
Merged
12 tasks
@Moisan Moisan mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blackheaven @codecov-commenter @orhun